Fix hard coding bug in partial vertical LGR setup; #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
aleaf
commented
Nov 14, 2024
aleaf
commented
- Improve robustness and clarity of starting heads options
- Add doc page for IC Package setup
… corners outside of the parent model grid
…ecify strt: from_model_top in source_data: block; needed in the case where there is a parent model and default_source_data is set to True. In this case, the default behavior was to set strt from the strt array in the parent model. fix(SFR Package setup:): when setting up inflows; try checking input sites against the routing dictionary as-is, or with the input sites as strings, to support versions of SFRmaker <= 0.11.3 (integer line identifiers) and > 0.11.3 (string line identifiers).
…_array that was causing vertical gaps between LGR inset and parent models with horizontal refinments other than 5.
…et starting heads from parent starting heads
…pdating starting heads from a previous run
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #98 +/- ##
===========================================
+ Coverage 89.47% 89.51% +0.03%
===========================================
Files 65 65
Lines 12992 13106 +114
===========================================
+ Hits 11625 11732 +107
- Misses 1367 1374 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.